test: regression test for 0 cve pdf report #4371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a regression test for 0-cve pdf report behaviour. This should help us avoid bugs that cause the report to fail in the case where 0 cves were found. This is the last piece needed to close intel#4326. Other pieces: * intel#4329 fixed the check that was causing report generaiton to fail. * intel#4354 changed the UI so it's more obvious when reportlab is needed. * fixes intel#4326 Signed-off-by: Terri Oda <terri.oda@intel.com>
nedsouza
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a regression test for 0-cve pdf report behaviour. This should help us avoid bugs that cause the report to fail in the case where 0 cves were found.
This is the last piece needed to close #4326. Other pieces:
fix: 0 cve pdf report was not generating #4329 fixed the check that was causing report generaiton to fail.
fix: halt if pdf selected but unavailable #4354 changed the UI so it's more obvious when reportlab is needed.
fixes in CVE Tool 3.2.1, --report parameter is not generate report file when no CVE found. Same issue observe in 3.3 #4326