feat(parser): add conan parser #4569
Conversation
Signed-off-by: Aryan Bakliwal <aryanbakliwal12345@gmail.com>
|
Hey @mastersans, could you please take a look and let me know if any change is required. I did test it and it is working as expected with the test passing locally. |
There was a problem hiding this comment.
Hey Thanks for the PR, Looks good to me, I have minor nit pick, @terriko might have something more to say.
There was a problem hiding this comment.
Looks promising. I'd like you to address @mastersans 's suggestions, particularly providing a link for some info about the conan.lock file format. But I'll get the tests running for you now.
Signed-off-by: Aryan Bakliwal <aryanbakliwal12345@gmail.com>
|
I've kicked off the tests to run. I'm still seeing some weirdness about the longtests (which have to pass before I can merge anything due to our branch rules) so if those fail due to timeout we may have other problems to resolve before this can be merged. |
Signed-off-by: Aryan Bakliwal <aryanbakliwal12345@gmail.com>
Signed-off-by: Aryan Bakliwal <aryanbakliwal12345@gmail.com>
|
@terriko I've added |
|
Kicking the tests off again. I'm still seeing failures in longtests that look like timeouts, though, so I don't know if those will pass right now. |
|
@terriko which tests are failing? |
|
Hm, it looks like the longtests ci job didn't actually run the conan test. I'm investigating. |
|
@terriko please do let me know if there is anything left from my side |
|
Just a note: the new test is failing for me locally, but I think it may be related to a cache issue, so I'm going to go update the cache and see where I'm at after that. |
|
I'm going to rebase this so we can take advantage of the new github actions config files and hopefully see the new test run as expected. |
terriko
added
awaiting maintainer
fixes: #4265
Added Conan package parser for C/C++.