-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update Sphinx and myst-parser versions; resolve warnings #4581
Conversation
I think if we're bothering to generate documents, it makes more sense to include them so they're reachable, so we might as well fix all those issues. Suggestions:
The last one is a little less important since I think people coming to look at the sboms are more likely to be browsing through git than the documentation, but who knows, maybe having that info on readthedocs will be useful to someone, and we've got a low-key goal of making sboms more accessible and usable so this seems to fit into that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited the title so it should pass the gitlint check next time the job runs (it won't update until you make changes).
It looks like spelling is complaining about 132 missing items. Since there's a lot of package and human names in there, I'd suggest we just add the whole sboms directory to the spelling exclude list, which can be found here: https://github.com/intel/cve-bin-tool/blob/main/.github/actions/spelling/excludes.txt
In my penultimate commit I addressed the following points:
I spent a few time trying to include hyperlinks in the sbom for humans documentation to directly open the json files but did not find a way that worked, attempts carried:
In my last commit I finally updated requirements.txt with the updated versions of Sphinx and myst-parser. Let me know your feedback. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've got a couple of extra files you'll need to delete: doc/=4.0.0
and doc/=8.0.2
-- looks like a couple of logs that got checked in by mistake.
testing to see if I can clean up those extra files for you
removing un-needed files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the web interface actually lets me remove the files for you, so I've gone ahead and done that. I think this should be good to go now, thank you again for working on it!
Thanks for taking the time to do that on my behalf @terriko ! |
Summary
This PR is intended to address issue #4311 (docs: upgrading sphinx & myst-parser)
Details
While building the documentation using
make docs
, I received the following warnings:I'm unsure whether these documents should be added to the toctree or if they're intentionally excluded.
Questions
Additional Notes