-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CVEDB] Fixes #4578(metric_finder function returns "unknown" #4656
base: main
Are you sure you want to change the base?
Conversation
Removed python3.8 from testing.yml as it is no longer getting security updates
…ntel#4604 Fixes intel#4604, improved alt-text in Architecture and Metrics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this contains your other PR. Quick tip: when making a new branch, make sure to start from one that doesn't have any changes in it. My norm is to have my "main" branch be kept directly in sync with "main" on intel/cve-bin-tool so you can use that as the base for all PRs. We've got some instructions here on how to do that: https://github.com/intel/cve-bin-tool/blob/main/CONTRIBUTING.md#making-a-new-branch--pull-request
That said, I've approved the tests to run anyhow so you can get some results. Just beware that if anything fails in your 3.8 PR it's going to fail here too and might make it harder to see if anything in the new code is causing issues.
Ok thanks for the tip i'll do that also the tests failed, ill look into it and fix it |
Fixes #4578 ([CVEDB] Why does the function metric_finder returns unknown or a metrics_id)
I think this should be good enough, let me know any changes are needed