Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVEDB] Fixes #4578(metric_finder function returns "unknown" #4656

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

vedpawar2254
Copy link
Contributor

@vedpawar2254 vedpawar2254 commented Dec 29, 2024

Fixes #4578 ([CVEDB] Why does the function metric_finder returns unknown or a metrics_id)

  1. Added "UNKNOWN" Metric
  2. Implemented a method (ensure_unknown_metric) to ensure it exists
  3. and updated the metric_finder function

I think this should be good enough, let me know any changes are needed

@vedpawar2254 vedpawar2254 changed the title [CVEDB] Fixes #4578 [CVEDB] Fixes #4578(metric_finder function returns "unknown" Dec 29, 2024
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this contains your other PR. Quick tip: when making a new branch, make sure to start from one that doesn't have any changes in it. My norm is to have my "main" branch be kept directly in sync with "main" on intel/cve-bin-tool so you can use that as the base for all PRs. We've got some instructions here on how to do that: https://github.com/intel/cve-bin-tool/blob/main/CONTRIBUTING.md#making-a-new-branch--pull-request

That said, I've approved the tests to run anyhow so you can get some results. Just beware that if anything fails in your 3.8 PR it's going to fail here too and might make it harder to see if anything in the new code is causing issues.

@vedpawar2254
Copy link
Contributor Author

Ok thanks for the tip i'll do that also the tests failed, ill look into it and fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CVEDB] Why does the function metric_finder returns unknown or a metrics_id
3 participants