RAII Types and more #213
Draft
RAII Types and more #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwaern-intel
commented
Sep 28, 2023
| @@ -1,2 +1,3 @@ | |||
| *~ | |||
| *.pyc | |||
| flycheck_* | |||
There was a problem hiding this comment.
This addition was because I got real tired of my rg taking me into files fisketur flycheck created, and adding a flycheck_* filter was the easiest way to avoid that. We may or may not want this in.
lwaern-intel
commented
Sep 28, 2023
| method ms(int i) -> (string) throws { | ||
| if (i > 4) throw; | ||
| return mk_string_f("%d", i); | ||
| } |
There was a problem hiding this comment.
Artifact, I moved the test using this method to 1.4/types/raii/T_various.
|
Verification #12261598: fail |
lwaern-intel
commented
Oct 2, 2023
| class Orphan(Expression): | ||
| """Expressions that evaluate to a value that is allocated on the stack, but | ||
| not belonging to any local variable. Archetypical example are function | ||
| applications.""" |
There was a problem hiding this comment.
This description was written in a better time when orphans were directly tied to C concepts. What they are nowadays are not so simple (Expression.orphan has the better description)
Besides the obvious (RAII architecture, vectors, strings), this includes:
1. `cast(initializer, ...)` syntax, and rework of associated logic
3. As a result of the above, compound literals. `cast({1,2,3}, int[3])` is now supported.
4. `a += initializer` syntax, and rework of associated logic. This means complex method calls can be used as RHS of `+=`/`-=`/etc.
5. Reworked statements' `toc`/`toc_inline` family
6. ExpressionInitializer.assign_to and Expression.write rework
7. The addition of "addressable" and "c_lval" to Expression, and an associated rework of lvalue-ness
8. Strict `DMLType.cmp`. Old implementation is still used in a few places and is called `cmp_fuzzy`
9. The ability to hash DML Types in a way compatible with the new strict cmp.
10. `extern cident(blabla) as dmlident;`.
11. Improved deserialization logic for arrays; doesn't need a stack frame per dimension
|
Verification run featuring incompatibility patch (#217): https://teamcity01-ir.devtools.intel.com/viewQueued.html?itemId=12292226 |
|
Verification without incompatibility: https://teamcity01-ir.devtools.intel.com/viewQueued.html?itemId=12292197 |
lwaern-intel
added a commit
that referenced
this pull request
May 27, 2024
Taken from #213, but with some refinements
lwaern-intel
added a commit
that referenced
this pull request
May 27, 2024
Taken from #213, but with some refinements
lwaern-intel
added a commit
that referenced
this pull request
May 27, 2024
Taken from #213, but with some refinements
lwaern-intel
added a commit
that referenced
this pull request
May 27, 2024
Taken from #213, but with some refinements
lwaern-intel
added a commit
that referenced
this pull request
May 27, 2024
Taken from #213, but with some refinements
lwaern-intel
added a commit
that referenced
this pull request
May 27, 2024
Taken from #213, but with some refinements
lwaern-intel
added a commit
that referenced
this pull request
May 29, 2024
Taken from #213, but with some refinements
lwaern-intel
added a commit
that referenced
this pull request
May 30, 2024
Taken from #213, but with some refinements
lwaern-intel
added a commit
that referenced
this pull request
Jun 10, 2024
Taken from #213, but with some refinements
lwaern-intel
added a commit
that referenced
this pull request
Jun 11, 2024
Taken from #213, but with some refinements
lwaern-intel
added a commit
that referenced
this pull request
Jun 11, 2024
Taken from #213, but with some refinements
lwaern-intel
added a commit
that referenced
this pull request
Jun 11, 2024
Taken from #213, but with some refinements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides the obvious (RAII architecture, vectors, strings), this includes:
cast(initializer, ...)syntax, and rework of associated logiccast({1,2,3}, int[3])is now supported.a += initializersyntax, and rework of associated logic. This means complex method calls can be used as RHS of+=/-=/etc.toc/toc_inlinefamilyDMLType.cmp. Old implementation is still used in a few places and is calledcmp_fuzzyextern cident(blabla) as dmlident;.This is a draft PR as it is way too massive to be merged in as-is. We should decide upon what we should split and how.
In addition, the tests in this PR are too basic -- they are touch-ups of the ad-hoc tests I made while working on this. They are not sufficient to e.g. exhaustively test the semantics of strings and vectors -- vectors in particular have some very complicated logic attached to them.
You'll spot a number of
TODO(RAII)s in the implementation -- these represent particular question marks where I feel the implementation could potentially be improved, rather than unimplemented components -- this PR is feature complete.