Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use GOMEGA in e2e tests #1490

Open
hj-johannes-lee opened this issue Aug 2, 2023 · 0 comments
Open

use GOMEGA in e2e tests #1490

hj-johannes-lee opened this issue Aug 2, 2023 · 0 comments
Labels
tests Test (including CI) related issue

Comments

@hj-johannes-lee
Copy link
Contributor

It makes more sense to use gomega assertions more similar to how envtest uses. For example:

err = e2epod.WaitForPodSuccessInNamespaceTimeout(...)
Expect(err).To(Succeed()), utils.PrintFormattedErrorAndLog(...))
...
@hj-johannes-lee hj-johannes-lee mentioned this issue Aug 2, 2023
Merged
@mythi mythi added the tests Test (including CI) related issue label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Test (including CI) related issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mythi @hj-johannes-lee