Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland upstream commit 67ea999 #2975

Closed
whitneywhtsang opened this issue Dec 10, 2024 · 1 comment · Fixed by #3062
Closed

Reland upstream commit 67ea999 #2975

whitneywhtsang opened this issue Dec 10, 2024 · 1 comment · Fixed by #3062
Assignees
@quintinwang5
Labels
upstream: rebase PR to be up-streamed
Milestone
0.2 [Triton] Upst...

Comments

@whitneywhtsang
Copy link
Contributor

whitneywhtsang commented Dec 10, 2024 •
edited
Loading

Reland 67ea999 that is temporarily reverted in #2972 by 7d0818a.
@whitneywhtsang whitneywhtsang added the upstream: rebase PR to be up-streamed label Dec 10, 2024
This was referenced Dec 10, 2024
Closed
Closed
@quintinwang5
Copy link
Contributor

Failures casued by this relanding:

test_reduce_layouts[sum-float16-False-reduce1d-0-src_layout7-16-16]
test_reduce_layouts[sum-int32-False-reduce1d-0-src_layout7-128-16]
test_reduce_layouts[max-int32-False-reduce1d-0-src_layout7-128-16]
test_reduce_layouts[sum-int32-True-reduce1d-0-src_layout7-128-16]
test_reduce_layouts[max-int32-True-reduce1d-0-src_layout7-128-16]
test_reduce_layouts[sum-float32-False-reduce1d-0-src_layout7-128-16]
test_reduce_layouts[max-float32-False-reduce1d-0-src_layout7-128-16]
test_reduce_layouts[max-float16-False-reduce1d-0-src_layout7-128-16]
test_reduce_layouts[max-int32-False-reduce1d-0-src_layout7-16-16]
test_reduce_layouts[sum-int32-True-reduce1d-0-src_layout7-16-16]
test_reduce_layouts[max-int32-True-reduce1d-0-src_layout7-16-16]
test_reduce_layouts[sum-float32-False-reduce1d-0-src_layout7-16-16]
test_reduce_layouts[max-float32-False-reduce1d-0-src_layout7-16-16]
test_reduce_layouts[max-float16-False-reduce1d-0-src_layout7-16-16]

There is already a workaround locally to fix all above failures, it's a matter of subgroupsize. WIP to find a more general soulution.

@vlad-penkin vlad-penkin added this to the 0.2 [Triton] Upstream milestone Dec 16, 2024
@whitneywhtsang whitneywhtsang mentioned this issue Dec 27, 2024
Merged
@quintinwang5 quintinwang5 linked a pull request Dec 30, 2024 that will close this issue
[WA] fix reduce layouts errors to reland 67ea999 #3062
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quintinwang5 quintinwang5

Labels
upstream: rebase PR to be up-streamed
Projects
None yet
Milestone
0.2 [Triton] Upstream
Development

Successfully merging a pull request may close this issue.

[WA] fix reduce layouts errors to reland 67ea999 intel/intel-xpu-backend-for-triton
3 participants
@whitneywhtsang @quintinwang5 @vlad-penkin