Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PVC skiplist for Rolling Driver #985

Closed
vlad-penkin opened this issue Apr 26, 2024 · 7 comments
Closed

Add PVC skiplist for Rolling Driver #985

vlad-penkin opened this issue Apr 26, 2024 · 7 comments

Comments

@vlad-penkin
Copy link
Contributor

No description provided.

@vlad-penkin vlad-penkin added this to the 8. Validation milestone Apr 26, 2024
@AshburnLee
Copy link
Contributor

AshburnLee commented May 8, 2024

The information and background in this issue is too limited to support my judgment and understanding, though I do have several solution proposals.

Solution#1 is that when platform is PVC && driver is rolling/LTS, skip ALL tests (just skip "test_triton").
Solution#2 is that we create a deselect file "pvc_lts_rolling.txt", and put all tests in to that file. Then when platform is PVC && driver is rolling/LTS, set "--deselect-from-file" as "pvc_lts_rolling.txt".

Solution#3 is that maybe when testing driver, not all test cases are needed, I have not thought that through, but maybe I will add a "test_xxx()" function in "test_driver.py".

Please provide some instructive advice. thanks
@pbchekin @vlad-penkin

@AshburnLee AshburnLee self-assigned this May 9, 2024
@vlad-penkin
Copy link
Contributor Author

vlad-penkin commented May 10, 2024

@AshburnLee see clarifications below:

  • All ~12K unit tests for xpu device are in scope -
    TRITON_DISABLE_LINE_INFO=1 TRITON_TEST_SUITE=language \
  • LTS and Rolling drivers for given HW architecture have different features and bugs, for each combination a separate skip lis is required

@AshburnLee
Copy link
Contributor

That's been helpful, thanks @vlad-penkin

@AshburnLee
Copy link
Contributor

My approach to getting skip list is different from Pavel‘s and Pavel has left comment about this, we'll discuss about it.

@AshburnLee
Copy link
Contributor

Pavel gave approval for PR#1093, need your approval @vlad-penkin.
BTW, PR#1196 is not target to this issue.

@AshburnLee
Copy link
Contributor

Automation script #1196 is not in the scope of this issue

@AshburnLee
Copy link
Contributor

Close this one as it has fixed and already approved by one reviewer but still waiting the other reviewer's approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants