Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UT] add skiplist for PVC w/ rolling driver #1093

Closed
wants to merge 1 commit into from
Closed

[UT] add skiplist for PVC w/ rolling driver #1093

wants to merge 1 commit into from

Conversation

AshburnLee
Copy link
Contributor

@AshburnLee AshburnLee commented May 11, 2024 •
edited
Loading

Functionality

Renamed default to pvc_rolling as pvc with rolling is the default platform.
Request: #985
This PR add a skiplist for pytest enables skipping ‘SKIPPED’ cases in script/skiplist/pvc_rolling when the platform is PVC with Rolling driver.

Result

After the change of this PR, the test sessions with deselect files skip all the SKIPPED test cases.

@AshburnLee AshburnLee self-assigned this May 11, 2024
@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch 2 times, most recently from 33298aa to 5bcc566 Compare May 11, 2024 08:14
@AshburnLee AshburnLee requested review from pbchekin, vlad-penkin and gshimansky and removed request for pbchekin and vlad-penkin May 11, 2024 08:14
@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch from 5bcc566 to 5c28b69 Compare May 13, 2024 00:56
pbchekin
pbchekin reviewed May 13, 2024
View reviewed changes
scripts/pytest-utils.sh Outdated Show resolved Hide resolved
pbchekin
pbchekin reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@pbchekin pbchekin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do not need to put the existing xfailed tests to the skiplist. We use skiplist for skipped tests instead. Also the default skiplist is for PVC with the rolling driver, no need to create a new one, instead consider renaming default to pvc-rolling.

vlad-penkin
vlad-penkin requested changes May 13, 2024
View reviewed changes
scripts/capture-hw-details.sh Outdated Show resolved Hide resolved
@vlad-penkin vlad-penkin linked an issue May 13, 2024 that may be closed by this pull request
Add PVC skiplist for Rolling Driver #985
Closed
@AshburnLee
Copy link
Contributor Author

AshburnLee commented May 14, 2024 •
edited
Loading

I think we do not need to put the existing xfailed tests to the skiplist. We use skiplist for skipped tests instead. Also the default skiplist is for PVC with the rolling driver, no need to create a new one, instead consider renaming default to pvc-rolling.

Oh, I may understand it wrong, I should have put skipped tests in the skiplist, not the xfailed. OK, will change that and renaming default file.

How about the xfailed cases? do we just leave it as it was? thansks @pbchekin

@pbchekin
Copy link
Contributor

How about the xfailed cases? do we just leave it as it was?

Yes

@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch 2 times, most recently from 67772d2 to e38cd31 Compare May 17, 2024 14:18
@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch from e38cd31 to a4f1ef4 Compare May 27, 2024 02:07
@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch 2 times, most recently from 639464c to 6ff3519 Compare June 6, 2024 02:00
@AshburnLee
Copy link
Contributor Author

AshburnLee commented Jun 10, 2024 •
edited
Loading

How about approving this PR? Just change the skip list default name as 'pvc_rolling'? @vlad-penkin @pbchekin

@pbchekin
Copy link
Contributor

@AshburnLee please sync the PR with the target branch, there is a change to the skip list in #1310.

@ESI-SYD ESI-SYD force-pushed the lijunhui/pvc_skiplist branch from 6ff3519 to 401b2ec Compare June 11, 2024 15:49
@AshburnLee
Copy link
Contributor Author

@AshburnLee please sync the PR with the target branch, there is a change to the skip list in #1310.

Done, thanks~

@vlad-penkin
Copy link
Contributor

@AshburnLee similar comment, please take into the account this PR:

@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch from 401b2ec to 983b129 Compare June 12, 2024 02:31
@AshburnLee
Copy link
Contributor Author

@AshburnLee similar comment, please take into the account this PR:

Updated, thanks~

@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch 2 times, most recently from 79d9085 to f112089 Compare June 13, 2024 03:45
@AshburnLee
Copy link
Contributor Author

Please give approval @vlad-penkin thanks~

@AshburnLee AshburnLee force-pushed the lijunhui/pvc_skiplist branch from f112089 to 9f46837 Compare June 14, 2024 16:39
@pbchekin
Copy link
Contributor

No longer needed.

@pbchekin pbchekin closed this Jul 10, 2024
@pbchekin pbchekin deleted the lijunhui/pvc_skiplist branch July 10, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshimansky gshimansky gshimansky left review comments

@pbchekin pbchekin pbchekin approved these changes

@vlad-penkin vlad-penkin Awaiting requested review from vlad-penkin

Assignees

@AshburnLee AshburnLee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PVC skiplist for Rolling Driver
4 participants
@AshburnLee @pbchekin @vlad-penkin @gshimansky