Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid post-processing generated LLVM IR #1150

Merged
merged 4 commits into from
May 21, 2024
Merged

Avoid post-processing generated LLVM IR #1150

merged 4 commits into from
May 21, 2024

Conversation

whitneywhtsang
Copy link
Contributor

No description provided.

@whitneywhtsang whitneywhtsang self-assigned this May 18, 2024
@whitneywhtsang whitneywhtsang marked this pull request as ready for review May 18, 2024 23:12
@whitneywhtsang whitneywhtsang linked an issue May 18, 2024 that may be closed by this pull request
Avoid post-processing generated LLVM IR #1077
Closed
@whitneywhtsang
Avoid post-processing generated LLVM IR
a4eed22 
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
sommerlukas
sommerlukas reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@sommerlukas sommerlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there is no testing of TritonGEN to LLVM IR in this PR.

#1087 solves this by introducing a simple triton-translate tool and then uses that tool to test translation to LLVM IR.

third_party/intel/include/Dialect/TritonGEN/IR/TritonGENDialect.td Show resolved Hide resolved
third_party/intel/lib/Target/LLVMIR/Dialect/TritonGEN/TritonGENToLLVMIRTranslation.cpp Show resolved Hide resolved
etiotto
etiotto approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@etiotto etiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding a lit test is optional because we have other tests that would fail if we are not able to pass the metadata for the required subgroup size, etc...

Adding more sanity checks in amendOperation is good.

@whitneywhtsang
address review comment
64f05e8 
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
@whitneywhtsang
Copy link
Contributor Author

It seems there is no testing of TritonGEN to LLVM IR in this PR.

#1087 solves this by introducing a simple triton-translate tool and then uses that tool to test translation to LLVM IR.

Added lit test.

@whitneywhtsang whitneywhtsang merged commit 04dc914 into llvm-target May 21, 2024
2 checks passed
@whitneywhtsang whitneywhtsang deleted the whitneywhtsang/llvm branch May 21, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiotto etiotto etiotto approved these changes

@sommerlukas sommerlukas sommerlukas approved these changes

Assignees

@whitneywhtsang whitneywhtsang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid post-processing generated LLVM IR
3 participants
@whitneywhtsang @sommerlukas @etiotto