Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal viable support for int8 on the block pointer path #1155

Merged
merged 21 commits into from
May 30, 2024
Merged

Minimal viable support for int8 on the block pointer path #1155

merged 21 commits into from
May 30, 2024

Conversation

jopperm
Copy link
Contributor

@jopperm jopperm commented May 20, 2024 •
edited
Loading

Adds an int8-variant to the block-pointer tutorial, and implements int8-support in the MatchTargetSize pass.

jopperm added 5 commits May 20, 2024 21:15
@jopperm
Prepare tutorial testcase for i8.
647bae4 
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
@jopperm
Get correctly shaped dpas instruction for int8.
c7bbe10 
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
@jopperm
Special-case pass for int8-GEMM.
a95221f 
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
@jopperm
Cleanup, pass result type as argument.
1267255 
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
@jopperm
yapf
1367c5a 
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
@jopperm jopperm force-pushed the jopperm/blockptr_i8 branch from 5dcd09d to 1367c5a Compare May 20, 2024 19:15
@vlad-penkin vlad-penkin linked an issue May 20, 2024 that may be closed by this pull request
Minimal viable support for int8 on the block pointer path #1157
Closed
@jopperm jopperm self-assigned this May 20, 2024
@jopperm jopperm linked an issue May 20, 2024 that may be closed by this pull request
[GEMM] Fix functional issues with non-float16 dtype #1097
Closed
8 tasks
@jopperm
Support vBlks==2 for int8.
98638b9 
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
@jopperm jopperm marked this pull request as ready for review May 21, 2024 09:15
Dewei-Wang-sh
Dewei-Wang-sh approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@Dewei-Wang-sh Dewei-Wang-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jopperm added 2 commits May 22, 2024 08:58
@jopperm
Unify tests.
d56cd33 
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
@jopperm
PR feedback.
69e9ab4 
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
jopperm added 3 commits May 22, 2024 15:14
@jopperm
Use ceil utility.
c4a4a34
@jopperm
Future-proof int type handling.
a482276 
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
@jopperm
I should enable format-on-save.
72d7c05 
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
whitneywhtsang
whitneywhtsang reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@whitneywhtsang whitneywhtsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the lit test, LGTM.

@jopperm
PR feedback, round 2.
629195b 
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
etiotto
etiotto approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@etiotto etiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding a lit test and addressing code review comments pending

third_party/intel/lib/TritonIntelGPUTransforms/MatchTargetSize.cpp Outdated Show resolved Hide resolved
jopperm added 4 commits May 27, 2024 16:18
@jopperm
Make shape of block memory accesses configurable.
98b64aa 
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
@jopperm
Add lit test.
f7acb5d 
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
@jopperm
Merge branch 'llvm-target' into jopperm/blockptr_i8
a240680
@jopperm
WS.
b1bee51
@jopperm
Copy link
Contributor Author

jopperm commented May 28, 2024

@etiotto @Dewei-Wang-sh Are you ok with this landing as well?

jopperm added 2 commits May 29, 2024 09:33
@jopperm
Merge remote-tracking branch 'origin/llvm-target' into blockptr_i8
18d0161
@jopperm
PR feedback.
a9cd6b1 
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
@jopperm jopperm mentioned this pull request May 29, 2024
Closed
8 tasks
etiotto
etiotto approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@etiotto etiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added a minor nit.

test/TritonIntelGPU/match-target-size.mlir Outdated Show resolved Hide resolved
jopperm added 2 commits May 29, 2024 16:35
@jopperm
Pull % into filecheck patterns.
115f4ec 
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
@jopperm
Merge branch 'llvm-target' into jopperm/blockptr_i8
8b7d806
@jopperm jopperm merged commit a84b0c9 into llvm-target May 30, 2024
2 checks passed
@jopperm jopperm deleted the jopperm/blockptr_i8 branch May 30, 2024 08:50
This was referenced May 30, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dewei-Wang-sh Dewei-Wang-sh Dewei-Wang-sh approved these changes

@FMarno FMarno FMarno left review comments

@etiotto etiotto etiotto approved these changes

@whitneywhtsang whitneywhtsang whitneywhtsang approved these changes

@victor-eds victor-eds victor-eds approved these changes

@sommerlukas sommerlukas Awaiting requested review from sommerlukas

@mfrancepillois mfrancepillois Awaiting requested review from mfrancepillois

Assignees

@jopperm jopperm

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@jopperm @FMarno @victor-eds @whitneywhtsang @etiotto @Dewei-Wang-sh