-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Input parameter to ignore test failures #1160
Conversation
run_name: | ||
description: Custom run name | ||
type: string | ||
default: "Build and test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem to be used anywhere in the workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used in line 2 to set a custom run name (https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#run-name). I am planning to use the run name by triggering this workflow externally, passing parameters, including the run name, for example, "Build and test on PVC with LTS".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -31,6 +40,10 @@ jobs: | |||
- spr | |||
- cpu | |||
steps: | |||
- name: Print inputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, because github sometimes puts null
for inputs
It is possible to run "Build and test" workflow manually and set
ignore_errors
to true to make sure the workflow executes all test suites and report failures. Using a common code to run tutorials in CI and in test-triton.sh.