Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Input parameter to ignore test failures #1160

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

pbchekin
Copy link
Contributor

It is possible to run "Build and test" workflow manually and set ignore_errors to true to make sure the workflow executes all test suites and report failures. Using a common code to run tutorials in CI and in test-triton.sh.

run_name:
description: Custom run name
type: string
default: "Build and test"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to be used anywhere in the workflow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used in line 2 to set a custom run name (https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#run-name). I am planning to use the run name by triggering this workflow externally, passing parameters, including the run name, for example, "Build and test on PVC with LTS".

Copy link
Contributor

@leshikus leshikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -31,6 +40,10 @@ jobs:
- spr
- cpu
steps:
- name: Print inputs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, because github sometimes puts null for inputs

@pbchekin pbchekin merged commit f634d91 into llvm-target May 22, 2024
7 of 8 checks passed
@pbchekin pbchekin deleted the ci-tutorials branch May 22, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants