-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UT] Automatically generate skiplist when on a new platform #1196
Conversation
704db1d
to
452da54
Compare
452da54
to
822134d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I understand what this PR does. Where exactly you replace pytest.skip()
calls?
The logic is this: if code is running on a new platform let's say
Those are generated from the Once we have this === Let me put it another way, there are two types of execution situations here:
=== So "replace" here is not real, "ignore" is more correct. As I think we are not supposed to modify the test code in PR, so this is a way to ignore. |
The steps for preparing a skip list for a new platform need to be different, see #987. For a new platform, you need to
Also no need to parse the pytest output, it is for humans. The existing script allows saving the test report in JUnit XML format that is machine readable. |
Good to know, let me do it manually and see what's the difference from my "naive" way ... |
I choose a smaller scope to reproduce the existing skiplist on PVC+Rolling, the scope is
Done, replaced
Done, I used the original
Done, I saved the report only with the following content:
It has
Here is what I think is weird, "skip list is generated by de-selecting all failed tests", then my skip list contains all My "naive" way is put all SKIPPED cases into the existing skiplist, which ready contains 4 FAILED cases. That is why I added 180 SKIPPED cases in the other PR (https://github.com/intel/intel-xpu-backend-for-triton/pull/1093/files#diff-4fa89506bbe5b7f399da9acb4709a0ab504aa68c09fddd90bb29f09b84aa4311) I haven‘t tried the JUnit XML script, but the result should be the same. (will try) I think I must have misunderstood something, could you point it out, thanks @pbchekin |
Implemented here:#1596 |
Functionality
issue#985 & issue#986 are solved by manually add skiplists, this PR automatically generate skiplist whenever on a new platform.
Result
A set of skiplists is generated and replace all
pytest.skip()
calls:Note
New script in this PR will be only executed when on a new platform, a new platform means that there exist no such a directory: /skiplist/${GPU}_${AGAMA}, script generates this directory for this new platform.
Fixes #1423