-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use stride instead of order to determine block attr #2349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengjunlu
reviewed
Sep 26, 2024
third_party/intel/lib/TritonIntelGPUTransforms/MaterializeBlockPointer.cpp
Outdated
Show resolved
Hide resolved
chengjunlu
approved these changes
Sep 26, 2024
alexbaden
force-pushed
the
alex/materialize_block_pointer_stride
branch
from
September 26, 2024 00:52
db2a0e9
to
c09e10e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a lit test?
third_party/intel/lib/TritonIntelGPUTransforms/MaterializeBlockPointer.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUTransforms/MaterializeBlockPointer.cpp
Outdated
Show resolved
Hide resolved
chengjunlu
approved these changes
Sep 26, 2024
The existing tests actually cover this scenario - because they change both the order and the stride.
But, I added one that covers this scenario + rewrite tensor pointer here: #2347 |
whitneywhtsang
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the Triton slack,
order
is unused on architecture below Hopper. But more importantly, order provides information that stride already has. In fact, order can be completely different from stride (i.e. wrong) and we still generate correct code. I think it is better to use the stride assuming the logic I added here makes sense.Note this depends on #2348, I'd like to land the debug logging separately, so we have it even if we decide to modify this approach. It was very useful in debugging this problem.
cc #2347