Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel outdated benchmark runs #2462

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Cancel outdated benchmark runs #2462

wants to merge 1 commit into from

Conversation

Egor-Krivov
Copy link
Contributor

@Egor-Krivov Egor-Krivov commented Oct 10, 2024

Currently each update to a PR runs benchmarks, which can take ~30mins to run. They can overload the runners and relevant runs will be delayed. At the same time there's rarely any point in outdated results.

Explanation about changes: https://stackoverflow.com/questions/66335225/how-to-cancel-previous-runs-in-the-pr-when-you-push-new-commitsupdate-the-curre

@Egor-Krivov Egor-Krivov requested a review from pbchekin October 10, 2024 16:05
@Egor-Krivov
Copy link
Contributor Author

@pbchekin What do you think?

Copy link
Contributor

@pbchekin pbchekin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Egor-Krivov
Copy link
Contributor Author

@pbchekin Could manual run be an issue? If I run this thing manually, I want each of them to be in separate group I guess.

@pbchekin
Copy link
Contributor

@pbchekin Could manual run be an issue? If I run this thing manually, I want each of them to be in separate group I guess.

Yeah, i think you can use this group id only for runs triggered by PRs, otherwise use a unique group id, for example github.run_id.

@Egor-Krivov
Copy link
Contributor Author

@pbchekin Could manual run be an issue? If I run this thing manually, I want each of them to be in separate group I guess.

Yeah, i think you can use this group id only for runs triggered by PRs, otherwise use a unique group id, for example github.run_id.

I'll add it then

@vlad-penkin vlad-penkin linked an issue Oct 11, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Cancel outdated benchmark CI runs
2 participants