Reduce diff with upstream code #2940
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
etiotto
commented
Dec 5, 2024
| // Dispatch to the corresponding dialect helper function to print the layout. | ||
| os << triton::gpu::getLayoutStr(tensorType, UseHWPointOfView); | ||
| return success(); | ||
| if (dialectName == "ttg") { |
There was a problem hiding this comment.
This code is the same as upstream, however it may not work for us. @chengjunlu ?
There was a problem hiding this comment.
No, this code wouldn't work for us.
We need to PR the changes to upstream to enable this tool work for third party dialect.
| auto shared = dyn_cast_or_null<triton::gpu::SharedEncodingAttr>( | ||
| dstType.getEncoding()); | ||
| auto shared = | ||
| dyn_cast<triton::gpu::SharedEncodingAttr>(dstType.getEncoding()); |
There was a problem hiding this comment.
This would make benchmark fail for the advanced path ? @quintinwang5 did you try to upstream this change ?
There was a problem hiding this comment.
Submitted something like this. They told me in ttgir every tensor must have a layout. So I think this is also unreasonable.
There was a problem hiding this comment.
We can remove this pass for advance path. Right? Because there is no convert layout operation used in advance path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.