Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use implicitly elapsed_time in autotuner #3036

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Don't use implicitly elapsed_time in autotuner #3036

wants to merge 6 commits into from

Conversation

anmyachev
Copy link
Contributor

@anmyachev anmyachev commented Dec 17, 2024 •
edited
Loading

The main idea of ​​this pull request is not to use elapsed_time that enable profiling mode for sycl queues, as this is not needed for profiling with PyTorch and PTI.

CI runs:

@anmyachev anmyachev linked an issue Dec 18, 2024 that may be closed by this pull request
Don't use implicitly elapsed_time in autotuner when profiling with PyTorch and PTI #3039
Open
@anmyachev anmyachev marked this pull request as ready for review December 18, 2024 13:51
anmyachev added a commit that referenced this pull request Dec 18, 2024
@anmyachev
try changes from #3036
2a4b818 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
Copy link
Contributor Author

@whitneywhtsang we can try the changes in #2484 on DLE runner, but we need to cherry-pick 2a4b818 into Pavel's branch

@whitneywhtsang
Copy link
Contributor

@whitneywhtsang we can try the changes in #2484 on DLE runner, but we need to cherry-pick 2a4b818 into Pavel's branch

Let's cherry-pick this PR to ptdb-dle-runner.

@anmyachev
Copy link
Contributor Author

anmyachev commented Dec 18, 2024 •
edited
Loading

@whitneywhtsang we can try the changes in #2484 on DLE runner, but we need to cherry-pick 2a4b818 into Pavel's branch

Let's cherry-pick this PR to ptdb-dle-runner.

ok, but let's use 2a4b818 (last commit in #2484) which compatible with changes on Pavel's branch

whitneywhtsang pushed a commit that referenced this pull request Dec 18, 2024
@anmyachev @whitneywhtsang
try changes from #3036
231b07a 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev added a commit that referenced this pull request Dec 18, 2024
@anmyachev
Revert "try changes from #3036"
0d66c8e 
This reverts commit 2a4b818.
@whitneywhtsang
Copy link
Contributor

Please rebase this PR.

anmyachev and others added 5 commits December 21, 2024 11:01
@anmyachev
Don't use implicitly 'elapsed_time' in autotuner
c4a40f4 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
pass a function for autotuner via 'do_bench' param
022d974 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
revert warmup/rep changes
de18b7a 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev @whitneywhtsang
Apply suggestions from code review
e82f873 
Co-authored-by: Whitney Tsang <whitney.tsang@intel.com>
@anmyachev
remove 'kernel_name'
5710fd1 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
Copy link
Contributor Author

Please rebase this PR.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitneywhtsang whitneywhtsang whitneywhtsang left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't use implicitly elapsed_time in autotuner when profiling with PyTorch and PTI
2 participants
@anmyachev @whitneywhtsang