-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply "[FRONTEND] added support for tuples (#5220)" #3043
Conversation
This reverts commit 492ea92.
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
On Triton's side I think I fixed everything. For Torch Inductor, even considering that I made several changes for it, this is still not enough and the full set of inductor tests does not pass. Considering the number of changes, I believe it is good idea to split it into another PR. |
I agree. I think we should remove the PyTorch patch from this PR and keep it in a separate branch since the inductor tests will fail either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the discussion, are we removing all debug prints and PyTorch patches in this PR?
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@alexbaden I can't completely remove the patch, because even the main tests will stop working. We have at least one test in the main set that uses PyTorch inductor:
@whitneywhtsang I removed debug things from the Triton code, but I intend to leave them in the patch, because they will still be useful for fixing the inductor tests (at least they highlight places that are affected by the change in the Triton interface). UPD: CI is not working now because there is no more space on the runners: |
Ops, sorry for that. Let me fix the problem, merge #3053, then I restart the workflow. |
|
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
This reverts commit 492ea92.
Summary of changes:
constexprs
are now also part of the signature. The format is:signature={..., 'o': "*fp32", '[Name of constexpr]': 'constexpr'}
ASTSource
there is parameter name change:constants
->constexprs
_add_common_properties
):divisibility_16
,equal_to_1
andequal_to_none
.Inductor CI: