Lower block pointer tt.load to 2DBlockRead
#959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiotto
reviewed
Apr 23, 2024
third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
chengjunlu
reviewed
Apr 24, 2024
LiyangLingIntel
force-pushed
the
liyang/2dload-to-llvm
branch
2 times, most recently
from
9581a6f to
326a86a
Compare
LiyangLingIntel
force-pushed
the
liyang/2dload-to-llvm
branch
from
326a86a to
1186477
Compare
This was
linked to
issues
Apr 24, 2024
chengjunlu
approved these changes
Apr 25, 2024
third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
Update the cast/dyn_cast style Change auto to explicit variable type when there is no hint Using ! to check nullptr
LiyangLingIntel
force-pushed
the
liyang/2dload-to-llvm
branch
from
2d9f6af to
c5847b2
Compare
Signed-off-by: Tiotto, Ettore <ettore.tiotto@intel.com>
etiotto
approved these changes
Apr 29, 2024
|
@whitneywhtsang take another look please. |
third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
whitneywhtsang
force-pushed
the
liyang/2dload-to-llvm
branch
2 times, most recently
from
27b6ca5 to
a6a52c1
Compare
whitneywhtsang
force-pushed
the
liyang/2dload-to-llvm
branch
from
a6a52c1 to
f55a08d
Compare
whitneywhtsang
approved these changes
Apr 29, 2024
…l-xpu-backend-for-triton into liyang/2dload-to-llvm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second PR separated from #941
This PR focuses on lowering
tt.loadwith tensor pointer toTriyton::Matrix2DBlockLoad.