Skip to content

Commit

Permalink
[Clang][NFC] Fix a test failure with mold linker (#122587)
Browse files Browse the repository at this point in the history
Mold prefers the suffix '$' for symbols like PLT and GOT entries, so
exclude these symbols as well. Otherwise, this test will fail for
developers using mold-linked Clang.

Closes llvm/llvm-project#76982
  • Loading branch information
zyn0217 authored Jan 11, 2025
1 parent 32bcd41 commit 77ef5a6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions clang/test/LibClang/symbols.test
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Check that there are no unversioned clang symbols in libclang.so
RUN: llvm-nm -Dj --defined-only %libclang | grep -v -e '@@LLVM_[0-9]\+$' | not grep '^clang'

# Check that here are no local clang_ symbols (ignoring symbols with .cold or
# Check that there are no local clang_ symbols (ignoring symbols with .cold or
# .localalias suffxies.)
RUN: llvm-nm %libclang | not grep '[a-z] clang_[^.]\+$'
RUN: llvm-nm %libclang | not grep '[a-z] clang_[^.$]\+$'

0 comments on commit 77ef5a6

Please sign in to comment.