Ort v1.15.0 ov changes customer a #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for LUID and handle OV warnings
sfatimar
reviewed
Sep 13, 2023
| @@ -88,7 +88,7 @@ CreateOVModel(const ONNX_NAMESPACE::ModelProto& model_proto, const GlobalContext | |||
| size_t index = results.size() - 1; | |||
|
|
|||
| for (auto it = results.rbegin(); it != results.rend(); ++it) { | |||
| if (auto const_node = std::dynamic_pointer_cast<ngraph::op::Constant>((*it)->input_value(0).get_node_shared_ptr())) { | |||
| if (auto const_node = std::dynamic_pointer_cast<ov::op::v0::Constant>((*it)->input_value(0).get_node_shared_ptr())) { | |||
There was a problem hiding this comment.
These are with API 2.0 as we are supporting only the latest three release of OV.
sfatimar
reviewed
Sep 13, 2023
| @@ -57,7 +57,7 @@ BasicBackend::BasicBackend(const ONNX_NAMESPACE::ModelProto& model_proto, | |||
| LOGS_DEFAULT(INFO) << log_tag << "Loaded model to the plugin"; | |||
| } else { | |||
| #if defined(OPENVINO_2023_0) | |||
| if (subgraph_context.precision != InferenceEngine::Precision::FP16) { | |||
| if (!subgraph_context_.has_dynamic_input_shape && dev_prec!="CPU_FP16") { | |||
There was a problem hiding this comment.
Has a bug been raised with OV team for CPU FP 16 Precision
There was a problem hiding this comment.
Not yet. Shall raise one.
sfatimar
reviewed
Sep 13, 2023
| @@ -257,7 +252,7 @@ void BackendManager::Compute(OrtKernelContext* context) { | |||
| } | |||
| #endif | |||
| bool use_dynamic_backend = true; | |||
| if (GetGlobalContext().enable_dynamic_shapes && subgraph_context_.has_dynamic_input_shape && | |||
| if (subgraph_context_.has_dynamic_input_shape && | |||
There was a problem hiding this comment.
For NPU we still need dynamic backend so maybe this logic wont be suitable going forward
There was a problem hiding this comment.
This logic is only skipping whether enable_dynamic_shapes runtime option is provided. According to this logic, if a model has dynamic shaped input it will be handled with dynamic backend.
sfatimar
reviewed
Sep 13, 2023
| std::pair<std::string, ov::Any> device_property; | ||
| device_property = std::make_pair("PLUGIN_THROTTLE", "1"); | ||
| device_config.emplace(ov::device::properties("GPU_CONFIG_KEY", device_property)); | ||
| // device_config[GPU_CONFIG_KEY(PLUGIN_THROTTLE)] = "1"; |
preetha-intel
force-pushed
the
ort_v1.15.0_ov_changes_customerA
branch
from
a62adeb
to
9112813
Compare
Add 2023.1 support; Fix string nullptr bug
Fix for when device_type is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes part of Customer A release - 1.15.0
Motivation and Context
Enabled features based on client requirements
This PR is created to review for SDLE.