Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty nodes to collect disonnected graphs? #17

Open
TheresaSchmidt opened this issue Jul 7, 2022 · 2 comments
Open

Add empty nodes to collect disonnected graphs? #17

TheresaSchmidt opened this issue Jul 7, 2022 · 2 comments
Assignees
Labels
bug Something isn't working data format question Further information is requested

Comments

@TheresaSchmidt
Copy link
Contributor

TheresaSchmidt commented Jul 7, 2022

Problem described in alignment-models/issues/7: When converting recipe graphs, into action graphs, nodes or sub-graphs can get cut off creating disconnected action graphs.

Proposed solution: Add one empty head node to each recipe graph, s.t. from all other nodes, there is a path to this head node and this node will be preserved in all conversions such as conversion to action graphs or FAT graphs.

@TheresaSchmidt
Copy link
Contributor Author

Open questions:

  • new code as option in json_to_conllu.py or as separate post-processing script?
  • what label should the new node have? Action? New label?

Note:

  • also need to update crowdsourcing scripts with the new data format
  • don't forget to mark as new version

@TheresaSchmidt
Copy link
Contributor Author

Other solution: Assuming that, if the sub-graphs are disconnected, the respective parts of the recipe could be executed independently, i.e. one after the other. Therefore we could connect the sub-graphs sequentially. Contra: doesn't preserve the information where the graphs were disonnected originally.

@TheresaSchmidt TheresaSchmidt changed the title Add empty nodes to collect disonnected graphs Add empty nodes to collect disonnected graphs? Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data format question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant