-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error running BERT tagger on CoLi servers #4
Comments
Hi, I've read that @siyutao you have many exams, should we say that you continue working on the allennlp 2.8 ELMo tagger and @TheresaSchmidt and I meet asap, run the allennlp 0.8 BERT tagger, and discuss debugging? Let me know what you think about this. |
Hey @irisferrazzo , that sounds good to me if you and Theresa have time this week. Otherwise I can spend some time this weekend on this issue too (but I think we decided moving ELMo to 2.8 is the priority?) I'll be a lot freer from the 22nd. Thanks! |
Hi @siyutao, yes you're right, but I want to respect the fact that you have many exams :) let's see if @TheresaSchmidt can this week or not. If not and you have some time this week/weekend to run and debug together instead of working on moving ELMo to 2.8, that would be obv better! Just don't want to put pressure on anybody :) |
This is really not the error I would expect from changing label_encoding. I would suspect an underlying that influences the different errors for BIOUL and BIO, respectively. But I'm really just guessing, too. Also, this week I'm still pretty busy but next week should be better. |
We've narrowed down the issue to the data. Somehow, with part of the data, the training runs through just fine (I tried with the German data and with cropped versions of the English data) but the full English data triggers the above error. I did a superficial search for white-space irregularities (have had problems with that before) but couldn't find anything. We could also try to look for gaps in the data. Maybe there's a line where not all columns are filled. |
Haven't found anything. |
If I use the attached file as training data, I get a dimension error (like the one above but with different numbers). If I split up the file into two separate files, each of the two files trains successfully. train_1222211.txt |
This last file actually has a last white line. Does it work though, right? I can have a look at the data now. I let you know if I find something |
I have tried yesterday to run the elmo tagger but I still don't have access to proj/cookbook (for the elmo weights etc., which I would prefer not to download). Could you also run it on the same data if you get to it? Then we doublecheck |
Here's a technical explanation why it's not working: allenai/allennlp#2851 However, this does not explain why it used to run through without a problem and suddenly doesn't do so anymore even though we haven't changed anything... |
Training with elmo runs as expected. Confirming that the problem is with the tokenization in bert. |
It seems like we need to change the way BERT embeds the recipes. The most quoted solutions is the addition of a sliding window allenai/allennlp#2537 |
a) The feature for sliding windows only came after allennlp0.8, right? So it would probably be quite an effort to implement it. |
Isn't the current implementation on allennlp 0.8.4? According to the release notes, 0.8.4. happens to be the release that added #2537. I already re-implemented the BERT in 2.8 and there wasn't an error with this but there was problem replicating the previously reported results as we've talked about. But agreed that we should prioritize moving ELMo. |
Ah ok. Then let's just postpone this, I think. |
We are sure that we haven't changed the data or the configuration of the model. This leaves only two possible factors that could have changed s.t. training the model doesn't work anymore (correct me if I missed something):
|
Currently getting error while running the allennlp0.8 BERT config tagger/tagger_with_bert_config.json after changing the label_encoding to "BIO" ("BIOUL" throws a different error)
Error output:
Another TO-DO: we need to add
min_padding_length
to config. May or may not be related to the current error.The text was updated successfully, but these errors were encountered: