Bump openapi_parser dependency to 2.0 #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brandur all pass except ruby 2.6. It looks like this new version of openapi_parser only supports 2.7 and up. 2.6 is pretty old and many libraries no longer supports. Rails dropped it in 7.0. So I think dropping it is reasonable. |
brandur
added a commit
that referenced
this pull request
Jan 14, 2024
Drop support for Ruby 2.6. 2.6 has been out of support for almost two years now (Mar 2022), and is causing a few issues with upgrading dependencies [1], so it's probably okay at this point for Committee to drop support for it. [1] #400
brandur
added a commit
that referenced
this pull request
Jan 14, 2024
Drop support for Ruby 2.6. 2.6 has been out of support for almost two years now (Mar 2022), and is causing a few issues with upgrading dependencies [1], so it's probably okay at this point for Committee to drop support for it. [1] #400
brandur
approved these changes
Jan 14, 2024
|
@brandur can we get a new release with these changes? 😄 |
|
@aburgel Yep, released as 5.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.0 of openapi_parser has a very useful fix to support nullable anyOf, allOf, oneOf types. This is a common way to handle nullable references.