Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Layout/ExtraSpacing #407

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Enable Layout/ExtraSpacing #407

merged 2 commits into from
Jan 23, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Jan 23, 2024

Since it only removes extra spaces and does not involve any destructive changes, I believe it should be fine. What do you think?

❯ bundle exec rubocop -A
....C.....................C................C.....................................

Offenses:

lib/committee.rb:25:31: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
    raise "remove deprecated!"  unless Committee::VERSION.start_with?("5")
                              ^
lib/committee/middleware/request_validation.rb:9:16: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
        @strict  = options[:strict]
               ^
lib/committee/schema_validator/option.rb:35:23: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
        @path_hash_key      = options[:path_hash_key] || "committee.path_hash"
                      ^^^^^

81 files inspected, 3 offenses detected, 3 offenses corrected

Since it only removes extra spaces and does not involve any destructive changes, I believe it should be fine. What do you think?

```
❯ bundle exec rubocop -A
....C.....................C................C.....................................

Offenses:

lib/committee.rb:25:31: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
    raise "remove deprecated!"  unless Committee::VERSION.start_with?("5")
                              ^
lib/committee/middleware/request_validation.rb:9:16: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
        @strict  = options[:strict]
               ^
lib/committee/schema_validator/option.rb:35:23: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
        @path_hash_key      = options[:path_hash_key] || "committee.path_hash"
                      ^^^^^

81 files inspected, 3 offenses detected, 3 offenses corrected
```
@ydah ydah changed the title Extra spacing Enable Layout/ExtraSpacing Jan 23, 2024
Copy link
Member

@brandur brandur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Thanks!

@brandur brandur merged commit 9430eb6 into interagent:master Jan 23, 2024
5 of 6 checks passed
@ydah ydah deleted the extra-spacing branch January 23, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants