Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update supported rubies #355

Merged
merged 2 commits into from
Oct 9, 2023
Merged

update supported rubies #355

merged 2 commits into from
Oct 9, 2023

Conversation

beanieboi
Copy link
Member

drop support for ruby 2.5, 2.6 and 2.7
add support for ruby 3.1 and 3.2

drop support for ruby 2.5, 2.6 and 2.7
add support for ruby 3.1 and 3.2
@beanieboi beanieboi mentioned this pull request Oct 9, 2023
@beanieboi beanieboi removed the request for review from jabrown85 October 9, 2023 13:22
@beanieboi beanieboi merged commit b66e3ae into master Oct 9, 2023
12 checks passed
@beanieboi beanieboi deleted the bf/ruby-updates branch October 9, 2023 15:26
@edmorley
Copy link

edmorley commented Feb 29, 2024

@beanieboi Hi! Should gem.required_ruby_version be set in pliny.gemspec too, to ensure newer pliny versions aren't incorrectly installed when using older Ruby?

Since Dependabot just opened a PR updating Cheverny to newer pliny, but CI still passed even though it's using Ruby 2.7 which is no longer tested in CI on pliny's side.

@beanieboi
Copy link
Member Author

@beanieboi Hi! Should gem.required_ruby_version be set in pliny.gemspec too, to ensure newer pliny versions aren't incorrectly installed when using older Ruby?

Since Dependabot just opened a PR updating Cheverny to newer pliny, but CI still passed even though it's using Ruby 2.7 which is no longer tested in CI on pliny's side.

Yeah that's a good idea. I opened #365 for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants