Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization Server should throw a GNAPServerRouteError if invalid token is used during rotation #3100

Open
njlie opened this issue Nov 15, 2024 · 0 comments · May be fixed by #3101
Open
Assignees
Labels
good first issue Good for newcomers pkg: auth Changes in the GNAP auth package.

Comments

@njlie
Copy link
Contributor

njlie commented Nov 15, 2024

The following conditional in the access token routes file does not throw a GNAPServerError like the rest of the errors in that route logic.

if (!newToken) {
throw new Error('invalid access token')
}

It should throw a 404 http code and a invalid_rotation GNAP error code.

@njlie njlie added good first issue Good for newcomers pkg: auth Changes in the GNAP auth package. labels Nov 15, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Nov 15, 2024
@golobitch golobitch self-assigned this Nov 17, 2024
@golobitch golobitch linked a pull request Nov 17, 2024 that will close this issue
6 tasks
@golobitch golobitch linked a pull request Nov 17, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers pkg: auth Changes in the GNAP auth package.
Projects
Status: Ready for Review
Development

Successfully merging a pull request may close this issue.

2 participants