Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixes 3084 #3088

Merged
merged 4 commits into from
Nov 13, 2024
Merged

docs: fixes 3084 #3088

merged 4 commits into from
Nov 13, 2024

Conversation

melissahenderson
Copy link
Contributor

@melissahenderson melissahenderson commented Nov 6, 2024

This PR covers doc issues that were discussed during a meeting with Max on Nov. 05, 2024.

@mkurapov Tagging you because of the YAML updates. Also, the OpenAPI spec for IdP is missing Continue Grant POST /interact/{id}/{nonce}. Is that intentional or should I create an issue for it?

@github-actions github-actions bot added pkg: backend Changes in the backend package. type: source Changes business logic pkg: auth Changes in the GNAP auth package. pkg: documentation Changes in the documentation package. labels Nov 6, 2024
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for brilliant-pasca-3e80ec ready!

Name Link
🔨 Latest commit 8a43c7e
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/673389d2a202830008e9f7ac
😎 Deploy Preview https://deploy-preview-3088--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mkurapov
Copy link
Contributor

mkurapov commented Nov 6, 2024

Also, the OpenAPI spec for IdP is missing Continue Grant POST /interact/{id}/{nonce}. Is that intentional or should I create an issue for it?

Continue Grant POST is for the Open Payments Auth API, so shouldn't be in the IdP spec

@melissahenderson melissahenderson merged commit be426fa into main Nov 13, 2024
42 checks passed
@melissahenderson melissahenderson deleted the mh-3084 branch November 13, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. pkg: documentation Changes in the documentation package. type: source Changes business logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants