Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user to gateway #1623

Merged
merged 3 commits into from
Sep 19, 2024
Merged

feat: add user to gateway #1623

merged 3 commits into from
Sep 19, 2024

Conversation

dragosp1011
Copy link
Contributor

Context

  • fixes #

Changes

@github-actions github-actions bot added package: wallet/backend Wallet backend implementations type: source Source changes labels Sep 19, 2024
@Tymmmy Tymmmy mentioned this pull request Sep 19, 2024
8 tasks
Copy link
Member

@beniaminmunteanu beniaminmunteanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

constructor(private env: Env) {
this.cache = new NodeCache({ stdTTL: 60 * 60 * 12 })
constructor(private gateHubClient: GateHubClient) {
this.cache = new NodeCache({ stdTTL: 60 })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the TTL smaller now?

Copy link
Contributor

@sanducb sanducb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too! 👍

@dragosp1011 dragosp1011 merged commit dbfd572 into main Sep 19, 2024
15 checks passed
@dragosp1011 dragosp1011 deleted the user-gateway branch September 19, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: wallet/backend Wallet backend implementations type: source Source changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants