Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet/backend): add view card details endpoint #1633

Merged
merged 13 commits into from
Sep 26, 2024
Merged

feat(wallet/backend): add view card details endpoint #1633

merged 13 commits into from
Sep 26, 2024

Conversation

sanducb
Copy link
Contributor

@sanducb sanducb commented Sep 19, 2024 •
edited
Loading

Context

Changes

This PR adds endpoints for getting all cards for a specific customer and full card details for a specific card.

Notes:

  • Keypair needed for getCardDetails endpoint will be generated and stored in the frontend, therefore publicKeyBase64 will be sent on the request to wallet backend.
  • Card details session will be handled in a different PR and ticket

@sanducb sanducb linked an issue Sep 19, 2024 that may be closed by this pull request
[Cards] Wallet Backend - View card details #1626
Closed
3 tasks
@github-actions github-actions bot added package: wallet/backend Wallet backend implementations type: source Source changes labels Sep 19, 2024
@sanducb sanducb changed the title Add view card details endpoint feat(backend): add view card details endpoint Sep 19, 2024
@sanducb sanducb changed the title feat(backend): add view card details endpoint feat(wallet/backend): add view card details endpoint Sep 19, 2024
@github-actions github-actions bot added the type: test Improvements or additions to tests label Sep 24, 2024
beniaminmunteanu
beniaminmunteanu previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@beniaminmunteanu beniaminmunteanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Would just add validation schemas and unit tests to verify throwing of 400 bad requests afterwards

@sanducb sanducb marked this pull request as ready for review September 25, 2024 17:21
beniaminmunteanu
beniaminmunteanu previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@beniaminmunteanu beniaminmunteanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦁

@sanducb sanducb merged commit 9bb15a9 into main Sep 26, 2024
15 checks passed
@sanducb sanducb deleted the 1626-cards-wallet-backend-view-card-details branch September 26, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragosp1011 dragosp1011 dragosp1011 approved these changes

@beniaminmunteanu beniaminmunteanu beniaminmunteanu approved these changes

Assignees
No one assigned
Labels
package: wallet/backend Wallet backend implementations type: source Source changes type: test Improvements or additions to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cards] Wallet Backend - View card details
3 participants
@sanducb @dragosp1011 @beniaminmunteanu