Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): replace rapyd with gatehub KYC #1643

Merged
merged 22 commits into from
Sep 24, 2024
Merged

feat(wallet): replace rapyd with gatehub KYC #1643

merged 22 commits into from
Sep 24, 2024

Conversation

dragosp1011
Copy link
Contributor

@github-actions github-actions bot added package: wallet/frontend Wallet frontend implementations package: wallet/backend Wallet backend implementations type: test Improvements or additions to tests type: source Source changes labels Sep 23, 2024
<div className="min-h-full flex-1 py-10">
<div className="mx-auto flex min-h-full w-full flex-col items-center sm:px-6 lg:px-20 xl:px-24">
<div className="min-h-full flex-1">
<div className="mx-auto flex h-screen w-full flex-col items-center px-2">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added h-screen here because min-h-full added a vertical scroll, and the links for registering and logging in were not shown on screen. Also this currently makes the theme toggle on mobile device overlap the logo, but we will remove the toggle soon.

  • padding is removed here because GateHub KYC has already padding

packages/wallet/backend/src/gatehub/client.ts Outdated Show resolved Hide resolved
packages/wallet/backend/src/gatehub/client.ts Outdated Show resolved Hide resolved
packages/wallet/backend/src/middleware/isAuth.ts Outdated Show resolved Hide resolved
packages/wallet/frontend/src/middleware.ts Show resolved Hide resolved
packages/wallet/frontend/src/pages/kyc.tsx Outdated Show resolved Hide resolved
packages/wallet/frontend/src/pages/kyc.tsx Show resolved Hide resolved
Copy link
Member

@beniaminmunteanu beniaminmunteanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dragosp1011 dragosp1011 merged commit 77d40b2 into main Sep 24, 2024
15 checks passed
@dragosp1011 dragosp1011 deleted the onboarding branch September 24, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: wallet/backend Wallet backend implementations package: wallet/frontend Wallet frontend implementations type: source Source changes type: test Improvements or additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GateHub] - Replace Rapyd KYC with GateHub KYC
5 participants