Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): await on get balance #1657

Merged
merged 2 commits into from
Oct 1, 2024
Merged

fix(wallet): await on get balance #1657

merged 2 commits into from
Oct 1, 2024

Conversation

dragosp1011
Copy link
Contributor

Context

  • fixes #

Changes

@github-actions github-actions bot added package: wallet/backend Wallet backend implementations type: source Source changes labels Sep 30, 2024
sanducb
sanducb previously approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@sanducb sanducb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only left one question

packages/wallet/backend/src/gatehub/types.ts Outdated Show resolved Hide resolved
@dragosp1011 dragosp1011 merged commit 5abc871 into main Oct 1, 2024
15 checks passed
@dragosp1011 dragosp1011 deleted the fix/get-balance branch October 1, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanducb sanducb sanducb approved these changes

@beniaminmunteanu beniaminmunteanu Awaiting requested review from beniaminmunteanu

@lengyel-arpad85 lengyel-arpad85 Awaiting requested review from lengyel-arpad85

@adrianboros adrianboros Awaiting requested review from adrianboros

Assignees
No one assigned
Labels
package: wallet/backend Wallet backend implementations type: source Source changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dragosp1011 @sanducb