-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet/backend): add view card transactions endpoint #1661
Merged
sanducb
merged 7 commits into
main
from
1629-cards-wallet-backend-view-card-transactions
Oct 2, 2024
Merged
feat(wallet/backend): add view card transactions endpoint #1661
sanducb
merged 7 commits into
main
from
1629-cards-wallet-backend-view-card-transactions
Oct 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
github-actions
bot
added
package: wallet/backend
Wallet backend implementations
type: source
Source changes
labels
Oct 1, 2024
dragosp1011
reviewed
Oct 1, 2024
@@ -102,3 +102,38 @@ export interface ICardLockRequest { | |||
export interface ICardUnlockRequest { | |||
note: string | |||
} | |||
|
|||
// Response for fetching card transactions | |||
export interface ITransaction { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any types that are used on frontend and backend should be in shared
dragosp1011
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: wallet/backend
Wallet backend implementations
type: source
Source changes
type: test
Improvements or additions to tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes
This PR adds the endpoint for viewing a card's transactions.