Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 1658 gatehub add tests for gatehub module #1671

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

feat: 1658 gatehub add tests for gatehub module #1671

wants to merge 24 commits into from

Conversation

adrianboros
Copy link
Contributor

Context

Added tests for gatehub module in wallet backend

@adrianboros adrianboros added package: wallet/backend Wallet backend implementations type: test Improvements or additions to tests labels Oct 2, 2024
@adrianboros adrianboros linked an issue Oct 2, 2024 that may be closed by this pull request
[GateHub] - Add tests for gatehub module #1658
Open
2 tasks
@adrianboros adrianboros changed the title 1658 gatehub add tests for gatehub module feat: 1658 gatehub add tests for gatehub module Oct 2, 2024
@adrianboros adrianboros marked this pull request as ready for review October 2, 2024 11:46
@adrianboros adrianboros marked this pull request as draft October 7, 2024 11:00
@github-actions github-actions bot added the type: source Source changes label Oct 7, 2024
adrianboros
adrianboros commented Oct 7, 2024
View reviewed changes
packages/wallet/backend/src/rafiki/service.ts
@@ -126,7 +234,8 @@ export class RafikiService implements IRafikiService {
if (
[
EventType.OutgoingPaymentCreated,
EventType.OutgoingPaymentCompleted
EventType.OutgoingPaymentCompleted,
EventType.OutgoingPaymentFailed
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fix here: We have to parse debitAmount even for OutgoingPaymentFailed event otherwise it throws a bad request error - few lines below - and the event is not handled at all

adrianboros and others added 13 commits November 4, 2024 08:42
@adrianboros
Merge branch 'main' into 1658-gatehub-add-tests-for-gatehub-module
8be89bb
@adrianboros
feat(wallet/backend,boutique/backend): DEV env - add hot reload for w…
75e6316 
…allet and boutique backends (#1740)

* setup wallet backend hot reload

* setup wallet backend hot reload dockerfile.dev

* setup boutique backend hot reload

* wallet hot reload watch also for shared folder changes

* fix watch share path and remove chokidar env var

* enable multiple types of local environment run configurations

* pretty fix

* fix pnpm lock
@Tymmmy
fix: Fix images in emails (#1786)
8777fef 
Fix images
@renovate
fix(deps): update dependency awilix to v12 (#1711)
f4f9340 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update radix-ui-primitives monorepo (#1704)
b84a07f 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency @eslint/compat to ^1.2.2 (#1787)
1e4f163 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency @types/jest to ^29.5.14 (#1788)
344958e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency eslint-plugin-react to ^7.37.2 (#1789)
8e2cae1 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency tailwindcss to ^3.4.14 (#1790)
d29686f 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency vite to ^5.4.10 (#1792)
656466e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency typescript to ^5.6.3 (#1791)
271e814 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@DarianM
fix: windows compat issues with pnpm dev cmd & env var syntax (#1743)
1428330 
* fix win compat issues with pnpm dev cmd and env var syntax

* readme

* add cross-env

---------

Co-authored-by: darian <darian@interledger.org>
fix the gatehub failing tests
9b1b5f2
@github-actions github-actions bot added type: documentation Improvements or additions to documentation package: wallet/frontend Wallet frontend implementations package: boutique/backend Boutique backend implementations package: boutique/frontend Boutique frontend implementations labels Nov 7, 2024
@github-actions github-actions bot removed type: documentation Improvements or additions to documentation package: wallet/frontend Wallet frontend implementations package: boutique/backend Boutique backend implementations package: boutique/frontend Boutique frontend implementations labels Nov 7, 2024
@DarianM DarianM marked this pull request as ready for review November 10, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragosp1011 dragosp1011 Awaiting requested review from dragosp1011

@sanducb sanducb Awaiting requested review from sanducb

@raducristianpopa raducristianpopa Awaiting requested review from raducristianpopa

@beniaminmunteanu beniaminmunteanu Awaiting requested review from beniaminmunteanu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
package: wallet/backend Wallet backend implementations type: source Source changes type: test Improvements or additions to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GateHub] - Add tests for gatehub module
3 participants
@adrianboros @Tymmmy @DarianM