fix(background): handle unpeered wallets; retry without waiting interval

[dianafulga]

• Closes [BUG] No warning when sending to real wallet from rafiki.money #394
• Closes Don't wait for payment interval if there's a failure that we can retry #469
• Closes [BUG] One time payment still leaves sending wallet, despite receiving the message "Could not facilitate payment for current website."  #296
• Part of Error handling/messages improvements #147

[raducristianpopa]

Extension builds preview

Name	Link
Latest commit	b1d5779
Latest job logs	Run #10282090648
	Download
	Download

[raducristianpopa]

@RabebOthmani

[raducristianpopa]

[RabebOthmani]

@raducristianpopa are these still waiting for me?

[raducristianpopa]

@raducristianpopa are these still waiting for me?

Yes. We added them here as well so you can see where and how they are displayed.

[RabebOthmani]

@raducristianpopa few thoughts before getting into the copy:
Across the extension, we use payment. Do we want to keep with payments (Unable to process a payment) or use sent money (unable to send money) ?
Thinking about the average user: will they understand what a peered or unpeered wallets mean? I think it's better to say we can't process the payment, you might need to check with your provider for more details

[RabebOthmani]

For the error message when a website is not monetized, let's go with "This site is not web monetized" (using web monetized on purpose to keep it in the context of web monetization)

[raducristianpopa]

Across the extension, we use payment. Do we want to keep with payments (Unable to process a payment) or use sent money (unable to send money) ?

Like you mentioned, we are using payment across the extension. Let's stick with this.

Thinking about the average user: will they understand what a peered or unpeered wallets mean? I think it's better to say we can't process the payment, you might need to check with your provider for more details

No, we should not mention peering for the end user. What I am not sure about is this part: you might need to check with your provider for more details. The user doesn't have any details about who the receiver is since we are not showing them the wallet addresses that we found in the page. What is the user going to tell to the support team for example?

[RabebOthmani]

No, we should not mention peering for the end user. What I am not sure about is this part: you might need to check with your provider for more details. The user doesn't have any details about who the receiver is since we are not showing them the wallet addresses that we found in the page. What is the user going to tell to the support team for example?

What I'm trying to communicate is the payment failed but that's not the extension's fault. How about : We are unable to process the payment due to issues beyond our control.

[RabebOthmani]

The last one, what do we mean by has invalid linked? Is that when it's a partial problem?

[raducristianpopa]

The last one, what do we mean by has invalid linked? Is that when it's a partial problem?

The has invalid links placeholder that we have, will be displayed to the user when the extension can not send money to the wallet addresses that were found in the page - continuous payments, not one time payments (in our case, mostly because on the peering). It's not a partial problem. For the partial problem - when we can send to at least one wallet address from the page, we are not going to show the warning.

[RabebOthmani]

We discussed all these scenarios from our perspective. Now that we're working on the message, I'm wondering if from the user's perspective, they are distinct scenarios. The one thing I could think about that would make this last case different (invalid links) is that potentially those links may change in the future. We could say " Currently, we are unable to process payments for this website. This might change in the future should you wish to keep the continuous payment going." What do you think @raducristianpopa

[RabebOthmani]

Final decision per the call: At the moment, you cannot pay this website.

[sidvishnoi]

The design looks a bit off at the moment.

(And some tiny code changes suggested)