fix(content-script): retrieve href through getAttribute
#472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: content
Extension builds preview
|
){kind=icon}
){kind=icon}
sidvishnoi
reviewed
Aug 5, 2024
Comment on lines
+493
to
+494
| if (!href) | ||
| throw new Error('Monetization link is missing the "href" attribute.') |
There was a problem hiding this comment.
Suggested change
| if (!href) | |
| throw new Error('Monetization link is missing the "href" attribute.') | |
| if (!href) { | |
| throw new Error('Monetization link is missing the "href" attribute.') | |
| } |
| throw new Error('Monetization link is missing the "href" attribute.') | ||
| checkWalletAddressUrlFormat(href) | ||
| const response = await checkWalletAddressUrlCall({ | ||
| walletAddressUrl: href |
There was a problem hiding this comment.
We could have whitespace here. Why not do the .trim() part here only (when assigning href)?
| @@ -220,7 +220,7 @@ export class MonetizationTagManager extends EventEmitter { | |||
| record.type === 'attributes' && | |||
| record.attributeName === 'href' && | |||
| target instanceof HTMLLinkElement && | |||
| target.href !== record.oldValue | |||
| target.getAttribute('href') !== record.oldValue | |||
There was a problem hiding this comment.
Is oldValue equivalent to getAttribute() or the property one?
Also, do we disallow protocol relative URls this way here or should only via the https:// check below?
|
Closing this for now - context: #473 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #.
Changes proposed in this pull request