Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch Awilix container injection mode to proxy #498

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

raducristianpopa
Copy link
Member

Context

Closes #497.

Changes proposed in this pull request

Switching to PROXY, will allow us to do mangling during minification.

@raducristianpopa raducristianpopa changed the title feat: swtich Awilix container injection mode to proxy feat: switch Awilix container injection mode to proxy Aug 12, 2024
@github-actions github-actions bot added area: content Improvements or additions to extension content script area: background Improvements or additions to extension background script labels Aug 12, 2024
@raducristianpopa
Copy link
Member Author

raducristianpopa commented Aug 12, 2024

Extension builds preview

Name Link
Latest commit 2c1bd20
Latest job logs Run #10420074816
BadgeDownload
BadgeDownload

@sidvishnoi sidvishnoi changed the title feat: switch Awilix container injection mode to proxy refactor: switch Awilix container injection mode to proxy Aug 12, 2024
@raducristianpopa raducristianpopa marked this pull request as ready for review August 16, 2024 12:34
sidvishnoi and others added 2 commits August 16, 2024 15:38
Co-authored-by: Radu-Cristian Popa <radu.popa@breakpointit.eu>
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mangle everything!

@raducristianpopa raducristianpopa merged commit 40b21c2 into main Aug 16, 2024
8 checks passed
@raducristianpopa raducristianpopa deleted the rp/497/switch-to-proxy-injection branch August 16, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script area: content Improvements or additions to extension content script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Awilix container injection mode from CLASSIC to PROXY
2 participants