Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix manifest path in get-built-version action #519

Merged
merged 2 commits into from
Aug 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/actions/get-built-version.cjs
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
// @ts-check
/* eslint-disable @typescript-eslint/no-unused-vars, @typescript-eslint/no-var-requires */
const path = require('node:path')
const fs = require('node:fs/promises')

/**
* Retrieves the manifest version from the built extension.
* @param {import('github-script').AsyncFunctionArguments} AsyncFunctionArguments
*/
module.exports = async ({ core }) => {
const manifestPath = path.join(__dirname, 'dist', 'chrome', 'manifest.json')
const manifest = await fs.readFile(manifestPath, 'utf8').then(JSON.parse)
const manifest = await fs
.readFile('./dist/chrome/manifest.json', 'utf8')
.then(JSON.parse)

core.setOutput('version', manifest.version)
}
3 changes: 3 additions & 0 deletions .github/workflows/nightly-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,7 @@ jobs:
dist/*.zip
tag_name: 'nightly'
name: Nightly ${{ steps.version.outputs.version }}
body: |
> [!warning]
> The Nightly build is for adventurous folks. It's updated daily with less-tested features and improvements.
prerelease: true