Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update popup tab data along with icon #611

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Commits on Sep 25, 2024

  1. fix: update popup data along with icon

    - refactor(PopupState): add all popup data related to tab under `tab`
       - `tabUrl` -> `tab.url`
       - `isSiteMonetized` -> `tab.status === 'monetized'`
       - `hasAllSessionsInvalid` -> `tab.status === 'all_sessions_invalid'`
    - refactor(monetization): extract `getPopupTabData` to tabState service
    - refactor(tabEvents): use `getPopupTabData` instead of multiple params
    
    Paves way to show more useful messages with `tab.status`
      (e.g. new tab, internal extension pages, non-https pages)
    sidvishnoi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9b59924 View commit details
    Browse the repository at this point in the history