Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(content): ignore non-monetization links when <link> removed #635

Merged
merged 2 commits into from
Oct 1, 2024
Merged

fix(content): ignore non-monetization links when <link> removed #635

merged 2 commits into from
Oct 1, 2024

Conversation

sidvishnoi
Copy link
Member

Context

Visiting some sites that remove link tags on load (in this case Google calendar) led to following error in console:

Uncaught (in promise) Error: Could not find details for monetization node <link rel="icon" id="favicon" type="image/x-icon" href="https://calendar.google.com/googlecalendar/images/favicons_2020q4/calendar_1.ico">
    at MonetizationLinkManager.onRemovedLink (content.js:3456:15)
    at content.js:3347:39
    at NodeList.forEach (<anonymous>)
    at MonetizationLinkManager.onWholeDocumentObserved (content.js:3345:31)

Changes proposed in this pull request

Ignore removed link nodes that aren't relevant.

@github-actions github-actions bot added the area: content Improvements or additions to extension content script label Oct 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited
Loading

Extension builds preview

Name Link
Latest commit 8301517
Latest job logs Run #11122479486
BadgeDownload
BadgeDownload

@sidvishnoi sidvishnoi merged commit 19f59c9 into main Oct 1, 2024
9 checks passed
@sidvishnoi sidvishnoi deleted the ignore-non-monetization-on-remove branch October 1, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengyel-arpad85 lengyel-arpad85 lengyel-arpad85 approved these changes

Assignees
No one assigned
Labels
area: content Improvements or additions to extension content script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidvishnoi @lengyel-arpad85