Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ConnectWalletForm): ask consent for automatic key addition #637

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(ConnectWalletForm): ask consent for automatic key addition #637

wants to merge 3 commits into from
+137 −43

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Oct 2, 2024 •
edited
Loading

Context

Changes proposed in this pull request

Screencast.from.02-10-24.09.22.43.PM.IST.webm

@github-actions github-actions bot added area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup area: i18n labels Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024 •
edited
Loading

Extension builds preview

Name Link
Latest commit b0c727a
Latest job logs Run #11160863572
BadgeDownload
BadgeDownload

@github-actions github-actions bot added the area: tests Improvements or additions to tests label Oct 2, 2024
sidvishnoi
sidvishnoi commented Oct 2, 2024
View reviewed changes
Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@sidvishnoi sidvishnoi changed the base branch from main to connect-preserve-errors October 2, 2024 14:11
@sidvishnoi sidvishnoi changed the base branch from connect-preserve-errors to main October 2, 2024 14:11
@sidvishnoi sidvishnoi changed the base branch from main to connect-preserve-errors October 2, 2024 14:13
Base automatically changed from connect-preserve-errors to main October 2, 2024 15:46
sidvishnoi
sidvishnoi commented Oct 2, 2024
View reviewed changes
Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@RabebOthmani
Copy link
Collaborator

@sidvishnoi Looks good. My only comment is if we can centre the message and buttons in the pop up

@sidvishnoi
Copy link
Member Author

sidvishnoi commented Oct 3, 2024 •
edited
Loading

Final: @RabebOthmani

@sidvishnoi sidvishnoi marked this pull request as ready for review October 3, 2024 11:10
RabebOthmani
RabebOthmani approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@RabebOthmani RabebOthmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RabebOthmani RabebOthmani RabebOthmani approved these changes

@raducristianpopa raducristianpopa Awaiting requested review from raducristianpopa

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script area: i18n area: popup Improvements or additions to extension popup area: tests Improvements or additions to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Setup]: Add consent screen before starting key-add automation
3 participants
@sidvishnoi @RabebOthmani @raducristianpopa