fix(ConnectWalletForm): preserve errors on popup reopen #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: background
Extension builds preview
|
){kind=icon}
){kind=icon}
|
Yes, so user knows what went wrong. For example, we open new tab, popup closes:
We need that context (even if we don't show error message). These will be cleared when user successfully connects (or resets when user tries to connect again, to be replaced with newer error message); or when browser is closed. Example when we won't show redirect page with error (but popup was closed on tab open): |
don't retry adding key if failed before popup open handle more issues on errors gone on reload handle more issues on errors gone on reload
sidvishnoi
force-pushed
the
connect-preserve-errors
branch
from
d8eca81
to
7057897
Compare
|
TODO: reset all error and state when wallet address is changed (or add a "reset" button somewhere in error message?) |
raducristianpopa
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Part of #613
Changes proposed in this pull request
Screencast.from.02-10-24.05.45.59.PM.IST.webm