Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bg/openPayments): redirect with right error on key-add failure #639

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(bg/openPayments): redirect with right error on key-add failure #639

wants to merge 1 commit into from

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Oct 2, 2024 •
edited
Loading

@raducristianpopa to make changes to /welcome screen first.

Part of #613

@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Extension builds preview

Name Link
Latest commit 87e76d0
Latest job logs Run #11144492023
BadgeDownload
BadgeDownload

raducristianpopa
raducristianpopa reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@raducristianpopa raducristianpopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we will probably still want the errorCode as well, and a possibility to pass a message from the extension directly (errorMessage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raducristianpopa raducristianpopa raducristianpopa left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidvishnoi @raducristianpopa