Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add button component #69

Merged
merged 13 commits into from
Jan 8, 2024
Merged

feat: add button component #69

merged 13 commits into from
Jan 8, 2024

Conversation

raducristianpopa
Copy link
Member

@raducristianpopa raducristianpopa commented Dec 21, 2023 •
edited
Loading

Context

Closes #49.

Changes proposed in this pull request

  • Adds a reusable button component with two variants: default and destructive
  • Jest setup/config update tor testing
  • Includes test for the button component
  • Extra: testing added in workflows

@github-actions github-actions bot added the area: popup Improvements or additions to extension popup label Dec 21, 2023
@github-actions github-actions bot removed the area: popup Improvements or additions to extension popup label Dec 21, 2023
@raducristianpopa raducristianpopa added the area: popup Improvements or additions to extension popup label Dec 21, 2023
@raducristianpopa
Copy link
Member Author

raducristianpopa commented Dec 21, 2023 •
edited
Loading

Extension builds preview

Name Link
Latest commit 3c0f858
Latest job logs Run #7286529367
BadgeDownload
BadgeDownload
BadgeDownload
BadgeDownload

@github-actions github-actions bot added the area: ci Improvements or additions to repository workflows label Dec 21, 2023
@raducristianpopa raducristianpopa marked this pull request as ready for review December 21, 2023 09:50
@raducristianpopa raducristianpopa merged commit 8386c32 into main Jan 8, 2024
9 checks passed
@raducristianpopa raducristianpopa deleted the rp--button-component branch January 8, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ionutanin ionutanin ionutanin approved these changes

@dianafulga dianafulga Awaiting requested review from dianafulga

Assignees
No one assigned
Labels
area: ci Improvements or additions to repository workflows area: popup Improvements or additions to extension popup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add button component
2 participants
@raducristianpopa @ionutanin