Support for filter #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daimor
force-pushed
the
master
branch
2 times, most recently
from
24f3c8d
to
4da33cf
Compare
gjsjohnmurray
requested changes
Apr 22, 2024
There was a problem hiding this comment.
I think we're safe from an SQL injection perspective.
I also haven't tested. My main concern is the changes in other areas unrelated to adding filters, it's possible that some of the main GitHub actions workflow changes were not expected. I'd appreciate confirmation/explanation on this.
@isc-rsingh should there be someone other than me reviewing this from an InterSystems dev perspective? Maybe Brett?
|
I'm hoping the CI changes will fix the CI failure in my #54 PR once merged. Ideally they would have been on their own PR, but I can live with them being part of this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for filters, e.g. to hide Ens packages use
'Ens*