Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple config files #12

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Conversation

enzozafra
Copy link
Contributor

@enzozafra enzozafra commented Oct 17, 2019

What Changed

Give the users ability to pass a config file to maven using params.

It is used as follows:

mvn test -DconfigFilePath="customconfig.properties"

Why

Issue: #9
Having a single config file for multiple accounts is confusing and error prone.

Todo:

  • Add tests
  • Add docs
  • Add yourself to contributors (run yarn contributors:add)

@enzozafra
Copy link
Contributor Author

enzozafra commented Oct 17, 2019

@pandian912
Hi! Please review this.

Also I could not run the project.. but this should still work. Can you test it? It should be simple to test :) thank you very much

@enzozafra
Copy link
Contributor Author

Hi @pandian912 any updates?

@pandian912 pandian912 merged commit 4451f13 into intuit:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants