Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing assets build step to the page on how to develop custo… #588

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Conversation

maxocub
Copy link
Contributor

@maxocub maxocub commented Oct 17, 2023

…m fields

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Copy link
Collaborator

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's just link-in the original source of information and I'll get this merged in.

Thanks for your contribution!

docs/develop/howtos/custom_fields.md Outdated Show resolved Hide resolved
Co-authored-by: Guillaume Viger <fenekku@fenekku.com>
@fenekku
Copy link
Collaborator

fenekku commented Oct 17, 2023

Ugh, new version of mkdocs / dependency out. I will take care of it soon.

@fenekku
Copy link
Collaborator

fenekku commented Oct 17, 2023

I had to push to your master branch @maxocub to fix the issue. Sorry about that!

But the issue is fixed. Thanks again!

@fenekku fenekku merged commit a4eb404 into inveniosoftware:master Oct 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants