Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customization: Add instructions for changing search button color #606

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Samk13
Copy link
Member

@Samk13 Samk13 commented Mar 8, 2024

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@Samk13 Samk13 added the documentation Improvements or additions to documentation label Mar 8, 2024
@Samk13 Samk13 changed the title customization: instructions for change search button color Customization: Instructions for change search button color Mar 8, 2024
@Samk13 Samk13 changed the title Customization: Instructions for change search button color Customization: Add instructions for changing search button color Mar 8, 2024
Copy link
Collaborator

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, can be merged after adjustments.

Comment on lines 30 to 36
To change the orange search button color, in your instance create `assets/less/site/elements/button.variables` file instead of the globals folder and add the following line to it:

```less
@searchButtonColor: /* your desired color */;
```

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that this is still needed. I have a note in my codebase saying that having to use button.variables could be deleted in v11. Maybe it has to do with something else on our side...

In any case, let's move this below the next paragraph with a little connection so as to get:

---start---

You can override any styling variable in your site.variables file. The available styling variables are typically found in the .variables files of the various Invenio modules installed (see note below).

For instance, to change the search button color, create the assets/less/site/elements/button.variables file (notice the use of the elements folder instead of the globals one) and add the following line to it:

@searchButtonColor: /* your desired color */;

---end---

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is implemented thanks for review @fenekku
I also explored the issue at InvenioRDM #1642 without success, yet the current approach seems effective. Let's proceed with this solution.

@Samk13 Samk13 merged commit fe0be70 into inveniosoftware:master Mar 13, 2024
1 check passed
@Samk13 Samk13 deleted the change-search-btn-color branch March 13, 2024 16:21
anikachurilova pushed a commit to anikachurilova/docs-invenio-rdm that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Released | Done 🚀
Development

Successfully merging this pull request may close these issues.

2 participants