Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a draft redirects to a hardcoded URL #1846

Open
karkraeg opened this issue Oct 17, 2024 · 3 comments · May be fixed by inveniosoftware/invenio-app-rdm#2889
Open

Deleting a draft redirects to a hardcoded URL #1846

karkraeg opened this issue Oct 17, 2024 · 3 comments · May be fixed by inveniosoftware/invenio-app-rdm#2889
Labels
bug Something isn't working

Comments

@karkraeg
Copy link
Member

In deposit.js the delete_ function has the redirect URL after deleting a draft hardcoded:

This should be read from the config value APP_RDM_DASHBOARD_ROUTES["uploads"] instead.

@karkraeg
Copy link
Member Author

@zzacharo as discussed tuesday in the telecon, could you provide some insight here as to how the flask config could best be read from the deposit.js? Thanks! The config object doesn't contain it.

@zzacharo
Copy link
Member

Hello,

I think it should be enough to inject the new variables in the form config:

That would go down to the deposit form state here and then it is available in the actions because of how we configure the redux store

Give it a go and let me know!

karkraeg added a commit to ulbmuenster/invenio-rdm-records that referenced this issue Oct 25, 2024
@karkraeg
Copy link
Member Author

Hi @zzacharo, thanks for your help! It will be fixed with inveniosoftware/invenio-app-rdm#2889 and #1859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants