Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collections: validate query passing the instance instead of hardcoding the class #1867

Open
alejandromumo opened this issue Oct 31, 2024 · 0 comments
Open

collections: validate query passing the instance instead of hardcoding the class #1867

alejandromumo opened this issue Oct 31, 2024 · 0 comments

Comments

@alejandromumo
Copy link
Member 

          What about using `self` here, even if it is a classmethod, instead of hardcoding?

            self.validate_query(self, kwargs["search_query"])

Otherwise, it is probably better to define validate_query as a static method, given that I can't override it.

Originally posted by @ntarocco in #1853 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alejandromumo